NFTchallenge with CSS custom properties and Flexbox

Community feedback

• 

  Byron•2,290

  @byronbyronPosted almost 3 years ago

  Not bad @Christ-Kevin

  I'd suggest having a look at the accessibility/html issues flagged by the FE mentor report 👍

  • All page content should be contained by landmarks
  • Bad value auto for attribute height on element img: Expected a digit but saw auto instead.
  • Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections.
  • etc.

  Other than that looks good! The massive height is a new one as well 😆

  0

  ---

  

  Christ Kevin Touga Watat•270

  @Christ-KevinPosted almost 3 years ago

  @byronbyron, thankyou for the feedback. But I have a question. What do you mean with "(...) The massive height is a new one as well " ? do you mean that the height of my container is massive ? or do you mean something else. If I made something wrong with this "massive height", could you explain me how i could avoid it ? Do you have a kind of solution ?

  0