Design comparison
Solution retrospective
I have problem with Preview page. So I will fix later
Community feedback
- @basitkoraiPosted over 1 year ago
Hi, my friend. 👋 I'm really glad you have completed the project
I have some suggestions to improve your project.
-
Fix the path of your images from this
<img src="/images/image-equilibrium.jpg" alt="">
to this<img src="./images/image-equilibrium.jpg" alt="">
just add a dot in front of the forward slash. -
Provide
alt=" "
text for the hero or any significant image to improve the accessibility. -
On your
<div class="card-container">
fix the padding. (I'd recommend 1rem). -
Remove the height from the
card-container
, because setting height explicitly destroys the responsiveness of your website. -
Instead of creating your card with
<div>
go for<article>
tags instead, as the<div>
don't have any semantic meaning. It will also increase your site's accessibility.
Upvote the comment if it helps
I hope these tips will help you improve your code.😊
Happy Coding✌️
Marked as helpful1@Jaiboon26Posted over 1 year agoThank you for reply my project.
I will improve my skills with your recommendations.
Best Regard.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord