NFT-card-preview-using-sass-and-flexbox

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, @R1loth! 👋

  Congratulations on completing this challenge! 🎉 It's great that the site is responsive without any media queries and all page content lives inside the correct landmarks! Good job! 👍

  However, there are some things that can be improved to make this solution even better.

  • It's important that any elements that have user interactivity should be wrapped by interactive elements like anchor tags. So, I recommend wrapping the Equilibrium image with an anchor tag instead of div.
  • I recommend making the overlay for the Equilibrium image with pure CSS. You can do that by using pseudo-element and background properties to show the cyan overlay and eye icon.
  • Alternative text for images should not be hyphenated (like code) and contain any words that are related to "image".
  • All icons are decorative images so I suggest leaving the alt="" empty.
  • Don't limit the height of the body element, it will not allow the users to scroll the page if the page content needs more height. Use min-height instead.
  • Use rem or sometimes em unit instead of px. Using px will not allow the users to control the size of the page based on their needs.

  That's it! Hope this helps. 😊

  Marked as helpful

  2