NFT-card-preview-Guido-Aranda

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Guido, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • remove all margin from .card-nft class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😁

  1

  ---

  

  Guido Aranda•120

  @GuidiUZPosted over 2 years ago

  @denielden Thanks for your time, I can implement your advice in a future challenge. <3 :D

  1
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello there! 👋

  Nice work on this challenge! Your solution is responsive! 👍

  Some suggestions from me.

  • In this case, all elements that have interactivity (Equilibrium image, Equilibrium #3429, and Jules Wyvern) should be wrapped by interactive elements (the same as the links inside the attribution).
  • I would recommend making the Equilibrium image as an actual img on the HTML. By doing this, you don't need to create an empty space for that image.
  • Alternative text for the avatar should be the creator's name.
  • For the absolute positioning of the eye icon, I recommend making the img-bg element position: relative to make it easier to put the eye icon in the middle of the image. Currently, at some screen sizes the eye is showing up outside of the card element (e.g. 800px width).

  Hope you find this useful!

  1

  ---

  

  Guido Aranda•120

  @GuidiUZPosted over 2 years ago

  @vanzasetia You are the best!!! I take your advice! <3

  0
• 

  P

  Oluwatoni Odetola•320

  @ToniHunter274Posted over 2 years ago

  I have never used them...what do they do?

  1

  ---

  

  Guido Aranda•120

  @GuidiUZPosted over 2 years ago

  @ToniHunter274 From what little I know, they are used to add static elements via the content property. There is a lot of documentation about it, I searched and searched and found what worked for me.

  0