NFT-card-grid-flexbox

Community feedback

• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Congrats on completing your first Frontend Mentor challenge, Brandon!

  It must've been quite challenging, but you've successfully made it and with each project you complete, you become a more competent and capable developer.

  Regarding what you said, there are many ways to approach a project. Obviously, there are some "best practices" commonly agreed on, but other than that, a lot of stuff in the coding world is subjective. It's important to realize that how someone coded a project isn't necessarily the best or the only way to do it.

  Now, I've had a look at your design and I looked through your code as well. Here are a few suggestions / observations based on that, in no particular order:

  1. I like how you structured your HTML - it's easy to read through. You might want to check out the BEM methodology for naming your classes and also look into HTML Semantic elements as they are a best practice when it comes to structuring your code for SEO and accessibility.

  2. On the smaller device sizes, there's an issue with the scaling of the card that creates a horizontal scrollbar. You might want to consider adding a media query to resize the card, so it fits the smaller viewports, without causing any scrolling.

  3. Consider using the * selector to target all elements when using the border-box property and also resetting the margin and padding for all the elements on the page as shown in this example https://stackoverflow.com/questions/46923610/css-resetting-margin-and-padding/46923672

  4. You added the display: grid property on the container, but that in itself doesn't affect the layout of the page. Therefore, making it redundant.

  5. You can create the hover effect just using the ::after and ::before pseudo-elements. You can have a look at how I did here https://github.com/Remus432/nft-preview-card-component/blob/main/styles.scss

  6. Consider using relative units such as %, rem, vh, and vw when building your UIs instead of px. That'll allow you to build more responsive and robust UIs that look great on all devices.

  7. Instead of using display: flex on the body element, you can use display: grid and the place-content: center properties to align vertically and horizontally your card.

  8. I like how you used @import for the Google Fonts - it's a neat way to keep your code more organized. (P.S: I might be biased because that's how I also approach Google Fonts imports ;))

  9. You set the height to auto on the equilibrium image, but that's redundant since the browser automatically calculates the height of the image based on the width. You don't need that line of code there.

  All in all, you've done a great job for your first Frontend Mentor challenge and I like how you've organized your HTML and CSS. You're on the right path and with each challenge, you'll continue sharpening your skills.

  Keep up the good work, Bradon! ;)

  Marked as helpful

  0

  ---

  

  Brandon•60

  @walker861Posted almost 3 years ago

  @Remus432 Thanks so much for your help! Your feedback is very thoughtful and nicely organized. I had a feeling the grid was not necessary but wanted to put something out to get feedback rather than keep tweaking and potentially break something.

  I’m hoping to revisit this card to see how I can use some of your suggestions to improve on the current solution. Again, thank you so so much! I will definitely pay it forward when I’m in a better position to leave feedback like this! Happy holidays!

  1
• 

  Mariam Fkini•80

  @Mariam-RfPosted almost 3 years ago

  Hello Brandon, I read your CSS and it's perfectly made. I have a note about the view icon because the most common solution is to add an overlay (div) on top of the image, with the icon inside of it. But the way you approached it is smart too and I like it. There's no better solution if you get right, it's just different approaches. Also, I think when it comes to grid, it's mainly left to a more complex layout with many columns and rows. That's the general opinion about it. I hope this helps and good luck :)

  Marked as helpful

  0

  ---

  

  Brandon•60

  @walker861Posted almost 3 years ago

  @Mariam-Rf Thanks for letting me know about the overlay. I'm grateful that you took the time to leave a response. I did have a moment where I thought I should try to get rid of any "display: grid" properties in my CSS and just stick to Flexbox. I will probably revisit this solution after I work out the second one. Thanks again! I'll be sure to pay it forward when I have a little more experience under my belt.

  1