Skip to content
Submitted over 1 year ago

Nft-card (pug + scss)

g4rfiEld•270
@evgeniy2002
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    ESSENTIALS ♻️:

    • This solution has generated accessibility error reports due to lack of title tag inside html element
    • <html> element must have a title tag, so fix it by adding <title>NFT Preview Card Component</title> inside the html

    HEADINGS ⚠️:

    • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>
    • Every site must want at least one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users) ----`

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
  • Hassia Issah•50,650
    @HassiaiPosted over 1 year ago

    You forgot to add the tittle tag within the head tag and give it content to fix the error issue. <head><tittle>Tittle of the html document</tittle></head>

    Replace <h2> with <h1> to fix the accessibility issue.

    Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

    Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord