Neil Kanakia• 300
@neilk17
Posted
Hey Abdallah,
Congrats on this challenge!
Few things you can improve on:
- There is a thin border around the users display pic. This can be added simply by adding the border attribute in your css file.
- There are a few accessibility issues that can be fixed easily: one of the main fixes you can do is adding landmarks (eg: header, footer, main, etc.) instead of using <div> tags everywhere
Good luck with other projects!
Marked as helpful
0
Abdallah Ahmed• 60
@AbdallahGO
Posted
thanks@neilk17
your feedback about accessibility it's so useful.
but the thin line you toke about it was <hr> as I make but it needs opasity:0.1;🤦♂️😹.
1