NFT_Card

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Abhishek, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • for the shadow read here
  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Abhishek Bhagat•40

  @abhishekb740Posted over 2 years ago

  @denielden thanks for your reply. I will definitely work on it.

  1
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. . Here are my suggestions 1.You should use <main class="container"> instead of <div class="container">. 2. Go down orderly when you are using the headings h1 down to h2 down to h3 and so on. 3. Also remove the color attribute on your hr tag.. 4. For your box shadow you can use a subtle px eg (0 3px 5px rgba(0,0,0,0.1)) . Regardless you did amazing.. Happy coding!!!

  Marked as helpful

  0