Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Hayley, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - to fix the effect
:hover
creating adiv
container of img for inhert the correct dimensions. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - remove all
margin
fromcard
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord