Frontend Mentor | NFT Responsive Card Component coding challenge solution

@PhoenixDev22

Posted over 2 years ago

Hello @david-oncu ,

I have some suggestions regarding your solution:

To tackle the accessibility issues:

Use <main> landmark to wrap the body content .HTML5 landmark elements are used to improve navigation .
Anything with a hover style in design means it's interactive. you need to add an interactive element<a> around the image Equilibrium #3429 and Jules Wyvern .
For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in( icon-ethereum, icon-clock ).
the icon-view doesn't really need to be in the html, you could do it with css. If you want it to stay in html it needs to be aria-hidden or role presentation with empty alt.
The avatar 's alt should be Jules Wyvern to it.
Read more how to write an alt text
the link should be wrapping the main image and either have Sr-only text, an aria-label or alt text that says where that link takes you.
You can use an unordered list<ul> to wrap class="card-split"and in each <li>, there would be <img > and<p> .
- I would use pseudo-elements . You either have to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo on hover.
Use min-height: 100vh for the <body>


body{
min-height: 100vh;/*using vh (viewport height) units to allow the body to set a minimum height value based upon the full height of the viewport. This also allows the body to to grow taller if the content outgrows the visible page.*/

width: 375px;an explicit width is not a good way . Remove the width from the main component and change it to max width instead. That will let it shrink a little when it needs to.
I would use pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo on hover.(rather and an extra div ) You might have a look at my solution , to see how I did the hover effect on the image , it might my helps.

Overall, your solution is good, Hopefully this feedback helps.

NFT Responsive Card Component

Design comparison

Solution retrospective

Community feedback

Please log in to post a comment

Join our Discord community