@PhoenixDev22
Posted
Hi Kamil,
Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:
HTML
- You can use the
<main>
landmark to wrap the NFT. And<footer>
landmark to wrap the attribution, using landmarks is important to improve navigation experience on your site for users of assistive technology
- The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..)
for this imagine what would happen when you click on the image, there are two possible ways:
1: If clicking the image would show a popup where the user can see the full NFT, here you use
<button>
. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use<a>
.
For the same reason, you can use <a>
to wrap Equilibrium #3429
.
- The link wrapping the equilibrium image should either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you.
- Images must have alt attribute. For any decorative images, each img tag should have empty
alt=""
and addaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in(icon-view, icon-ethereum, icon-clock ).
- Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be empty. You can use the creator's name
Jules Wyvern
. Read more how to write an alt text
- For middle part of the card
class="nft-eth-days-container"
, you can use an unordered list<ul>
, in each<li>
there should be<svg>
and<p>
. That way you can align them centrally.
- There are so many ways to do the hover effect on the image, The one I would use is pseudo elements
::before, ::after
. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.
Hopefully this feedback helps.
Marked as helpful
@kamilp522
Posted
Thanks for the feedback!
It's a whole lot of great advice. I'm still learning the basics and some of the html semantics still haven't set in my head.
I'll certainly go through everything you pointed out as I'll update this project in the future.
Thanks!!!
@PhoenixDev22
Posted
@kamilp522 Glad to help. Happy coding!