@PhoenixDev22
Posted
Hello
Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:
HTML
-
Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways: 1: If clicking the image would show a popup where the user can see the full NFT, here you use
<button>
. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use<a>
. For the same reason , you can use<a>
to wrapEquilibrium #3429
. -
The link wrapping the equilibrium image should either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you. -
For any decorative images, each img tag should have empty
alt=""
as you did and addaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in(icon-ethereum, icon-clock
). look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content -
To use more semantic tags , you may use
<figure>
and<figcaption>
for the avatar's part. -
Don’t include “image of” or “picture of” in the alt text . You can use only the creator's name
Jules Wyvern
. Read more how to write an alt text -
For middle part of the card
id="stats"
, you can use an unordered list<ul>
, in each<li>
there should be<img>
and<p>
that way you can align them centrally.
There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after
. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.
Aside these, great work on this one.
Marked as helpful
@Radexman
Posted
@PhoenixDev22 Thank you for such detailed feedback! Definitely some good advice there.
@PhoenixDev22
Posted
@Radexman Happy coding!