NFT Price Card

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello 👋Bn-Bushra, I think you did a good job.

  I have some suggestions though.

  1 I noticed

  <section class="nft-name">
        Equilibrium #3429
      </section>
  

  On the card it was supposed to be some sort of heading so an h1 would have been better.And also remember to make your code semantic which means to provide additional information that helps define the roles and relative importance of the different parts of your page. Using a section tag to wrap texts ruins accessibility.

  2 The avatar image`s alt attribute should have the name of the person on the pic.i.e alt="Jules Wyvern"

  I hope this helps 🙃

  Your solution looks amazing 🤩

  Happy coding ✌️

  1

  ---

  

  Bn-Bushra•290

  @Bn-BushraPosted 10 months ago

  @rayaatta Thanks for taking your time to go through my solution. I'll ensure that I use at least one h1 heading per page, limit the use of section tags and provide alt text for images at all time.

  0

  

  raya•2,870

  @rayaattaPosted 10 months ago

  Actually I am not saying you should limit the use of section tags,I am saying you should not wrap text inside them directly rather you should use text wrapping elements such as <p>,<a>,<span>,<h1>-<h6> for that@Bn-Bushra

  0