NFT preview-card

Community feedback

• 

  Muhammadh•1,140

  @Mr-jawPosted almost 2 years ago

  Hello there

  Great job on completing the challenge

  HTML 📄

  • avoid using <span> tags to display text since, it is mainly used for grouping elements purposes. Rather use a <h1> tag instead <span class="title highlight">Equilibrium #3429</span>, And <p> tag instead <span class="subtitle">Our Equilibrium collection promotes balance and calm.</span> since it is a descriptive text. Also using sematic HTML will improve the accessibility of the website.

  Learn more about sematic HTML here

  CSS 🎨

  I like the fact that you used CSS custom properties

  • you can completely get rid of the javascript and add these lines of code in the CSS to achive the same results

  .img_container:hover .layover_div{
      opacity: 1
  }
  

  I hope this was useful 😊

  HAPPY CODING

  Marked as helpful

  0