nft preview whithout flexbox and grid

Community feedback

• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @FrancisKhaledKhodja~ Congratulate on your solution to the challenge on FM platform. I have studied your work, and learned a lot from it. Especially BEM structuring is the one I fancy here.

  Here are some tips I like to advice on this one.

  1. Adding transitions on hover effect will make this one more wonderful.
  2. Missing border on avatar image.

  Happy coding ~

  Marked as helpful

  1

  ---

  

  Francis•260

  @FrancisKhaledKhodjaPosted almost 3 years ago

  @tymren608 Thanks a lot for your advice. Today, I do not master these technics but I will try to implement them next time.

  0
• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Hey Francis, good job on completing the challenge!

  It came out looking nice and the features work as expected. Only a few suggestions that I have to offer based on the code and final solution:

  • Your card isn't vertically centered. There are a lot of ways to center an element in CSS https://www.youtube.com/watch?v=njdJeu95p6s&ab_channel=Fireship

  • There should be more space above the .card__author element

  • You can import your fonts from Google Fonts straight into your CSS files by using @import

  • Some of your code gets repetitive because you have a second CSS file that uses some of the same CSS code. Try to use media queries instead so you can achieve the responsive design intended

  Marked as helpful

  0

  ---

  

  Francis•260

  @FrancisKhaledKhodjaPosted almost 3 years ago

  @Remus432 Hello Remus. thanks a lot for your feedback and advises. For my next challenge, I will keep your advice in mind...

  0