Skip to content
Submitted over 2 years ago

NFT preview using HMTL + CSS

Jesse•120
@hambergjesse
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • VicDev ☪︎•330
    @ViicDevPosted over 2 years ago

    I can help you with some recommendations, if you like it you can add me to my networks on my profile, we are here for anything @hambergjesse ☺

    0
  • Naveen Gumaste•10,480
    @NaveenGumastePosted over 2 years ago

    Hello Jesse ! Congo 👏 on completing this challenge

    Let's look at some of your issues, shall we:

    • For article and section tags you must use a heading tag for ex: - Consider using h2-h6 elements to add identifying headings to all sections. Check my article on accessibility issues

    • Warp your card content around the main tag Ex: 👇

    <body>
<main class="container">
*all you content here*
</main>
</body>

    happy Coding😀

    0
  • Travolgi 🍕•31,400
    @denieldenPosted over 2 years ago

    Hi Jesse, I took some time to look at your solution and you did a great job!

    Also I have some tips for improving your code:

    • add main tag and wrap the card for Accessibility
    • add descriptive text in the alt attribute of the image
    • To make it look as close to the design as possible add overflow: hidden; and border-radius: 1rem; to .container .main-image class
    • remove all margin from container class because with flex they are superfluous
    • try to use flexbox to the body for center the card. Read here -> best flex guide
    • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

    Overall you did well :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord