Skip to content
Submitted over 1 year ago

NFT preview project.

klass1cal•90
@Niksona0
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Shaxboz•1,230
    @shakhboz-shukhratPosted over 1 year ago

    Hello there👋! Congratulations on completing this challenge!

    There are a few issues with the provided code:

    1. The closing h1 tag should be </h1>, not </h3>.
    2. It's recommended to keep all CSS in an external stylesheet rather than inline styles. Moving the styles from the style element to an external file would be better.
    3. The span tag in the footer is not closed properly. It should be </span> instead of <span>.

    Here's the corrected code:

    <!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <link rel="stylesheet" href="css/style.css">
  <link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png">
  <title>Frontend Mentor | NFT preview card component</title>
</head>
<body>
  <main>
    <section>
      <div class="hero-img\"><img src=\"images/bg.jpg"></div>
      <h1>Equilibrium #3429</h1>
      <p>Our Equilibrium collection promotes balance and calm.</p>
      <div class="details">
        <p class="ETH"><img src="images/icon-ethereum.svg"> 0.041 ETH</p>
        <p class="time\"><img src="images/icon-clock.svg"> 3 days left</p>
      </div>
      <hr>
      <footer>
        <p><img src="images/image-avatar.png"><span class="txt">Creation of <span class="name">Jules Wyvern</span></span></p>
      </footer>
    </section>
  </main>
</body>
</html>

    Anyway, your solution is great. Hope you will find this helpful. Happy coding!

    Marked as helpful
    0
    klass1cal•90
    @Niksona0Posted over 1 year ago

    @Trueboss
    thank you <3 tried to fixed everything thanks to you.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord