Design comparison
Community feedback
- @Lauro235Posted almost 3 years ago
Hi Kensie,
You did a really great job here so well done. You made a really good use out of flexbox.
Some suggestions.
Your HTML could be more semantically meaningful. I accept that the main point of this is to make your design look good, but consider swapping the div#container for a section#container and maybe you could wrap the h1 tag with a header..
These little things are good practice and will help make future projects more accessible which is very important. Do a bit of a defragment of your CSS and remove any code not being used.
On classes vs IDs. I think the reason why people suggest classes over id's is because developers can leverage rules of one class across multiple elements. This can be used to make our code more succinct and follows principles of dry (do not repeat yourself) nicely.
It might be worth exploring the BEM structuring method. Even if parts of it seem counter intuitive to you. Learning and implementing a new structuring method - for say a month - is very useful and can be stated in your CV's and interviews. Employers will respect the effort you went to in order to adapt your practice.
Well done for your really excellent work and don't be disheartened by my criticism. I think you nailed the design and that's honestly the most important thing in the beginning.
2@kensiecodesPosted almost 3 years ago@Lauro235 Thank you so much for your lengthy and thoughtful feedback! It's so helpful. There's a lot of terminology here that I haven't been introduced to yet so you have given me a lot of new information to dig into. I really appreciate it!
1 - @anoshaahmedPosted almost 3 years ago
Hey good job on this challenge! Wrap everything in your body in
<main>... OR use semantic tags! .... you can also giverole=""to the direct children of your<body>but that's a little frowned upon... Click here to read more:)
1@kensiecodesPosted almost 3 years ago@anoshaahmed Oh, right, thank you so much for pointing this out! I'll take a look at the link too.
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord