Skip to content
Submitted almost 2 years ago

NFT Preview Page

Mirm•80
@Missteeme31
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I completed this challenge with the help of a tutorial. However, I did have issues making the dice image responsive using media queries. All constructive feedback would be greatly appreciated.

Community feedback

  • Mishael•320
    @mishael-codesPosted almost 2 years ago

    Hello Mirm,

    You did some fine work.👏👏

    However, I have a couple of suggestions to make your code even better.

    1) To improve the site's accessibility, try using the <main> tag on the <div> with the class of container. That is, instead of:

    <div class="container">

    you can have a <main> tag with the div inside of it. Like this...

    <main>
     <div class="container"></div>
</main>

    and for the <div class="creator"> try using the <footer> tag instead, like this <footer class = "creator">

    2) You can add

    main{
  display: flex;
  align-items: center;
  justify-content: center;
  min-height: 100vh
}

    to your CSS code to center the container div perfectly, in a way that it won't stick to the top of the viewport.

    3) In future projects, try adding a <title> in the <head> tag of your HTML code as this sets a title for your page and therefore, helps with the site's SEO.

    Once again, you did great on this project

    I can't wait to see what you build next.🙂

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord