Design comparison
Solution retrospective
Any advice on how to improve it's responsivity would be greatly appreciated
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! Here are some suggestions to help improve your code:
-
You want to make the adjustments from the comments of the other member.
-
The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
The Icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
-
Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an Anchor Tags <a>. The anchor tag will allow users to click on content and have them directed to another part of your site.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful1 -
- @correlucasPosted about 2 years ago
👾Hello @Clement1kalu-okereke, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
The image is getting distorted, to avoid this behavior, use these steps, first add
display: block
andmax-width: 100%
to the<img>
selector. To improve the responsiveness even more by adding the auto-crop property you can addobject-fit: cover
to make the image crop inside the container. Here’s the code:img { display: block; object-fit: cover; max-width: 100%; }
✌️ I hope this helps you and happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord