@rembiszkacper
Posted
Hi, your solution looks great!
I have a suggestion for improvement:
📌 Think about using <main>
to wrap your main content instead of <div>
.
Imagine <div>
and <span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.
This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
Try to use values such as em or rem, this will help you with the responsiveness of the website, e.g. in the body instead of
min-height:700px;
use
min-height: 100vh;
Marked as helpful
@selvaganapathy0605
Posted
Thank You Mr.@rembiszkacper for your suggestion.I'm definitely going to change it.