Design comparison
Solution retrospective
🚀Hello! Feekes👋,
🎯This is my solution for the NFT Preview card using HTML and CSS. I am using flexbox style to this project. Responsive design also worked for this challenge.
Mobile first approach is always best.
As usual If you notice any improvement, feel free to give out your tips to improve my coding skills are Welcome🙏
Have a nice da
Community feedback
- @rembiszkacperPosted 8 months ago
Hi, your solution looks great!
I have a suggestion for improvement:
📌 Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
Try to use values such as em or rem, this will help you with the responsiveness of the website, e.g. in the body instead of
min-height:700px;
usemin-height: 100vh;
Marked as helpful1@selvaganapathy0605Posted 8 months agoThank You Mr.@rembiszkacper for your suggestion.I'm definitely going to change it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord