NFT Preview Challenge with CSS Flexbox

Community feedback

• 

  Cody Lewis Zites•570

  @zitescodyPosted almost 3 years ago

  Amaka, great work on this. I like the custom properties you declared in your CSS. It is one of my favorite features.

  Let's eliminate some of those accessibility issues outlined in your report...

  I noticed you used both <h1> and <h3> tags, but not <h2>. The tag that should follow <h1> is <h2>. It is a pretty simple fix!

  I would replace <section class="container"> with <main class="container">, as the container contains the main content of this project.

  Also, instead of <div class="attribution">, use <footer class="attribution">. When possible, your HTML should be contained by landmarks <main>, <section>, <footer>, etc.

  Here are some AWESOME articles that help clarify the use of these tags!

  Heading Levels: https://dequeuniversity.com/rules/axe/4.3/heading-order?application=axeAPI

  Landmarks: https://dequeuniversity.com/rules/axe/4.3/region?application=axeAPI

  Please mark my feedback as helpful if you benefitted from it. Happy coding! And good work.

  Marked as helpful

  0
• 

  Amaka•100

  @amakaogujioforPosted almost 3 years ago

  Thanks a whole lot Cody for the feedback.

  0