NFT Preview - Challenge

Community feedback

• 

  Adriano•38,040

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Yuri Mendes, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5

  <h1>Equilibrium #3429</h1>

  To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      flex-direction: column;
      justify-content: center;
      min-height: 100vh;
  }
  

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Yuri Mendes•130

  @Yuri-MendesPosted almost 2 years ago

  @AdrianoEscarabote When I change the element to h1, it change the whole size of the font, and when I try to add a font-weight, it doesn't aply the color and another features I did added to project. What would it be your solution?

  1

  

  Adriano•38,040

  @AdrianoEscarabotePosted almost 2 years ago

  @Yuri-Mendes baixei o seu código aqui e fiz isso:

  h1{
    font-weight: 200;
    font-size: 1.25rem;
  }
  

  ta funcionando normal, ele tava ficando grande por causa q tava herdando o font-size do normalize.css

  Marked as helpful

  0

  

  Yuri Mendes•130

  @Yuri-MendesPosted almost 2 years ago

  @AdrianoEscarabote fiz diferente, com uma classe e deu certo tbm:

  .heading-1{ font-size: 120%!important; line-height: 120%!important; }

  0

  

  Adriano•38,040

  @AdrianoEscarabotePosted almost 2 years ago

  @Yuri-Mendes boaa

  1
• 

  Yuri Mendes•130

  @Yuri-MendesPosted almost 2 years ago

  Hey Adriano, I'm doing fine and you?

  So, the body does have display flex, and all others tags that you pointed it out. Did you check the css style file?

  About the h1, ok I will adjust, thanks.

  1