Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Your session has expired please log in again.
Your session has expired please log in again.

Submitted

NFT Preview Card(HTML&CSS)

Tharun Raj 1,310

@Code-Beaker

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi there! I have done a lot of work on this one. Or maybe a bit too much. I feel like the code is just too much. I would be glad If anyone could look into the code and tell me how I can simplify my CSS and write better code.

Also, This time I have got a perfect validation report from the site. I'm happy about that. Thank you!

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

Tharun Raj 1,310

@Code-Beaker

Posted

@0xAbdulKhalid Thanks for the tips! Happy Coding!

0
Sachin 830

@Sachin-Mahato

Posted

Great job for completing the challenge.

This challenge consists of two parts: the mobile component and the desktop component. However, it appears that the mobile part has not been developed. It's important to address this issue and ensure that the challenge's mobile and desktop aspects are completed.

.Usage of absolute units instead of relative units:

  • Absolute units like pixels (px) are used for defining lengths and sizes instead of relative units like percentages (%), em, or rem.
  • Relative units are more flexible and responsive across different screen sizes.

More-details

Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset

I hope you find this helpful and happy coding.

Marked as helpful

1

Tharun Raj 1,310

@Code-Beaker

Posted

@Sachin0000000 Hello there! Thanks for the reply!

I didn't even know that you could actually get these custom CSS resets. I will defenitely look into it.

Happy Coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord