NFT Preview card

Community feedback

• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @sob16 ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • Please try BEM for naming element classes. It will help you a lot on bigger projects.
  • There is no hover effects on image and other elements. It's also one of challenging part here.

  https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  0

  ---

  

  sbrn•200

  @imamsobirinPosted almost 3 years ago

  @tymren608 thank you for your feedback. I didn't notice that there should be a hover effect hehe.. and BEM? it sound new for me. I will learn about it

  0
• 

  darryncodes•6,390

  @darryncodesPosted almost 3 years ago

  This comment was deleted almost 3 years ago

  0

  ---

  

  darryncodes•6,390

  @darryncodesPosted almost 3 years ago

  whoops i've deleted my comment! Looks great @sob16 nice one.

  I'd recommend adding display: block; to this .container .header-img .header it'll get rid of the border/line thing created on hover at the bottom of the image 🤙

  1

  

  sbrn•200

  @imamsobirinPosted almost 3 years ago

  @darryncodes wow thank you darryn, it looks better now

  1