NFT preview card with image overlay and flexbox
Design comparison
Solution retrospective
This is my 2nd FEM challenge as a beginner and feedback is highly appreciated.
Community feedback
- @Faerk77Posted almost 3 years ago
Hey! @sandeshad100 Excellent work.
If you want to center it just add "heigth: 100vh;" on body, then "margin: auto"; on the card element.
100vh to use all the space available in the screen, then margin auto to center the container over that free space.
Here my solution & how i resolved it. https://www.frontendmentor.io/solutions/html-and-css-KcWgiM6ha
Grettings!
Marked as helpful1@sandeshad100Posted almost 3 years ago@Faerk77 Thanks I centered it but by editing it in my github css file but it is not applied to SOLUTION ---- DESIGN (comparison system of FEM)
0@Faerk77Posted almost 3 years ago@sandeshad100 You have to submit the solution again or just make a Screeshots to refresh the live URL but becareful, if you aren't premium you will have limited screenshots per month.
0 - @rsrclabPosted almost 3 years ago
Hi, @sandeshad100 ~
Congratulate on your 2nd solution on FM challenges. I have studied your work and it looks great. I have learned much from your work, and here is some of the tips I want to provide.
- I think implementing transition on hover effects would make your work more brilliant.
- I hope you to class the parent element as card and try to use BEM structuring in classing elements. That would be big advantage when you work on bigger projects.
- Why didn't you try to vertically center the card?
https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH
Here is my solution to this challenge, and I hope this could help you even a bit.
Happy coding!
Marked as helpful1@sandeshad100Posted almost 3 years ago@tymren608 I appreciate your feedback. Next I want to learn resposive design any tip/resources for that!
0@sandeshad100Posted almost 3 years ago@tymren608 Thanks and I knew about BEM structuring because of you.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord