Design comparison
Solution retrospective
i am starting with HTML5 and CSS3, all feedback and comments are welcome. it's with great honor to learn from others! thanks 😁
Community feedback
- @xsaulPosted over 2 years ago
Hello Tenzin! There are a few things with your design. First, the images are not displaying and it is because in your HTML file you are grabbing the images from a folder called "images" but the images you uploaded one by one and not in a folder. Also below the card is duplicated the text so you should remove it. And finally, I think would be better if you make the height and width way much smaller because it is a card and not a full-size element.
Work on that and your design will be much better! 😃
Marked as helpful0@lekdupPosted over 2 years ago@xsaul Thank you very much for your time! i couldn't upload the images folder in github i am new to that as well but i will google it and try to figure it out! and will definitely change those wdith and heights. thanks again!
0@xsaulPosted over 2 years ago@lekdup Well for the images you can do two things: 1.- Remove the "images/" and write it like this <img src="icon-clock.svg" alt="clock"> for this case I think that will be easier. or 2.- When you start your project create a folder called images (or any name you wanna) inside the main folder and like that you would have to write it like you already did.
Sure no problem, if you have any doubt write me another message here.
Marked as helpful0@lekdupPosted over 2 years ago@xsaul i did the 2nd option and made those changes as you said but it seems like i am not doing it completely right, because i don't see any difference 😅!
0@xsaulPosted over 2 years ago@lekdup I see the changes in your site and now the images are good haha, I think you mean in the design comparison slider and for that, you need to generate a new screenshot. Also, remember to make the width and height smaller!
Marked as helpful0@lekdupPosted over 2 years ago@xsaul hey buddy, i had a question i hope you don't mind. i couldn't figure out why the height of the hover and the overlay image itself have this little difference?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord