NFT preview card using scss

Community feedback

• 

  Suleman Tasawar•380

  @Suleman-TasawarPosted over 1 year ago

  Hi there, @Aq1q

  I viewed your solution to NFT preview card using scss.Your code looks clean but there is a problem with the display in large screen.In this case my screen resolution is 1366x786.In large screens its causing stretching in the image and the preview component in taking up almost the entire screen.The display on the mobile screen is fine.

  After viewing your code i noticed that you are % unit to set the width of the container and in your case you are using 80% of the width on the screen.You can use the units like px,rem which is a good way to set the width of any container.Try fixing the width

  Otherwise your code looks well structured on organized.

  Happy Coding

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0