NFT preview card using React, SCSS & csstyle

Community feedback

• 

  Dawid Keyser•170

  @dawkey95Posted over 1 year ago

  Hey,

  Loved seeing your solution using react and SCSS.

  How did you go about passing the accessibility reports and html validation? I always end up with landmark errors etc. I use Material UI as my CSS framework but can't figure out how to pass the accessiblity/html validation reports so thought I would check with you and how you approached it.

  Kind regards

  0

  ---

  

  Mohammed Hassan•240

  @MrMohammedMathPosted over 1 year ago

  @dawkey95 Thank you, I don't know how Material UI convert their components to HTML, but one of my suggestions to change the div element with id="root" to main element with the same ID. I think this will reduce the number of accessibility & HTML reports

  1

  

  Dawid Keyser•170

  @dawkey95Posted over 1 year ago

  @MrMohammedMath I will give that a go and see how that effects the reports. So basically instead of it saying

  <div id='root'> <App /> </div>

  it should be

  <main id='root'> <App /> </main>

  0

  

  Mohammed Hassan•240

  @MrMohammedMathPosted over 1 year ago

  @dawkey95 yes

  0