NFT preview card using HTML, Sass and Javascript
Design comparison
Solution retrospective
What do you guys think about the responsiveness? What do you think about the visual aspect of the page? does it look good? What are some practices that you think can be improved?
Community feedback
- @JoelLHPosted over 2 years ago
Hello, overall looks great! Good job. I have a couple of issues with the live site tho:
-
Did u use breakpoints for the container div? U can use width: 100% so u can get rid of the breakpoints and it will do a better job.
-
Theres a wierd glicth going on with the img overlay it looks like its flickering, not sure if it is my computher
Marked as helpful0@RicardoFuentes437Posted over 2 years ago@JoelLH Hello, thank you for you kind comments, regarding the container div i'll definitely use the "width: 100%" for the next challenge, i tried using "width: 100vw" but for some reason it didn't work as planned, but i thought it didn't look that bad so i just left it like that. And regarding the overlay, i don't see the glitch on my computer, i'm not sure what could be causing it.
Kind regards.
0 -
- @Enmanuel-Otero-MontanoPosted over 2 years ago
Hola Ricardo! Felicidades por completar el desafío¡
Tu solución es buena y tu diseño es responsive 👌. Por otro lado para mejorar podrías usar lo menos que puedas los divs y en cambio usar etiquetas con sentido semántico. El div con la clase container podrías eliminarlo y usar el main ya que lo tienes puesto con la misma clase, ahí te ahorrarías y div y tu diseño se mantendría. Y el div con la clase card-container cambiarlo por una etiqueta section. Así tu web sería más semántica.
En sentido general 👍
Saludos
Marked as helpful0@RicardoFuentes437Posted over 2 years ago@Enmanuel-Otero-Montano Hola que tal, muchas gracias por las recomendaciones, definitivamente las implementaré para el próximo desafío :)
Saludos
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord