Design comparison
SolutionDesign
Solution retrospective
I was confused with the active state for the image, I was pondering wether to have it be a link embedded in an image or a hover state. I ended up going with the latter and my approach may have been different if I went and embedded a link to the image.
Community feedback
- @fernandolapazPosted over 1 year ago
Hi π, perhaps some of this may interest you:
HTML, ACCESSIBILITY:
- Regarding your comment, when there is a hover state over an element it means that it is interactive, so there must be an interactive element around it (like a link or a button). So, we should use a
<a>
or<button>
to wrap the image (depending on what happened when clicking on it).
- Every page should have an
<h1>
to improve user experience and because it is an important element when it comes to SEO. And it is good not to skip heading levels (start with<h1>
, then<h2>
, and so on).
CSS:
- You might consider using some CSS reset as a good practice at the start of each project, to have a clean starting point and reduce differences between browsers. A popular CSS Reset from Josh Comeau π
For example, these are some very common and useful ones:
*, *::before, *::after { box-sizing: border-box; margin: 0; padding: 0; }
This will remove the vertical scrollbar you have, for example.
Please let me know if you want more info on any of these topics or disagree with something. I hope itβs useful π
Regards,
Marked as helpful1 - Regarding your comment, when there is a hover state over an element it means that it is interactive, so there must be an interactive element around it (like a link or a button). So, we should use a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord