Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @defydef, some suggestions to improve you code:
-To center you content to your page, add the following to your Body Element:
body { min-height: 100vh; display: grid; place-content: center; }
-
Change the
width
of the card container tomax-width: 320px
for it to not only responsive but also the correct width. -
The hover overlay is the incorrect color and the eye icon is not in the correct position. This need fixing.
-
The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an Anchor Tags <a>. The anchor tag will allow users to click on content and have them directed to another part of your site.
Happy Coding! 👻🎃
Marked as helpful0@defydefPosted about 2 years ago@vcarames thank you for your suggestions, I have applied them 😄
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord