Design comparison
Solution retrospective
Any feedback on the way I implemented the overlay?
Community feedback
- @shashreesamuelPosted over 2 years ago
Hey DavidPelo, good job completing this challenge. Keep up the good work
Your solution looks good however I think the font weight of your title should be increased, the same goes for the currency in the cyan color.
In terms of your accessibility issues
-
images must have alternative text, you can achieve this by adding in the
alt
attribute in your image tag and specifying a description of your image. This will be useful for screen readers or if the image is referenced incorrectly and fails to show on your webpage. -
Wrap all your content between
<main>
tags to avoid the other accessibility issues. I strongly recommend reading on html semantic tags and using them in your code since they will get rid of all your accessibility issues. You can read more on html semantic tags and it's usage here
https://www.w3schools.com/html/html5_semantic_elements.asp
In terms of your html validation errors once you fix the accessibility errors then your validation errors should disappear
I hope this helps
Cheers, Happy coding š
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord