Design comparison
SolutionDesign
Community feedback
- @fernandolapazPosted over 1 year ago
Hi ππ», some of this may interest you:
HTML:
- When there is a hover state over an element it means that it is interactive, so there must be an interactive element around it (like a link or a button). So, we should use a
<a>
or<button>
to wrap the image (depending on what happened when clicking on it). Also 'Equilibrium #3429' and 'Jules Wyvern' should be wrapped with the<a>
tag.
CSS:
- It is better to use
min-height: 100vh;
, as usingheight
causes the page to be cut off in viewports with small height (such as mobile landscape orientation).
- Think about using relative units like rem also for the
font-size
since they are better for scalable layouts.
- It might be good to get used to designing with the Mobile first approach, which means designing for mobile first and then for desktop or any other device, as it is widely considered best practice.
I hope itβs useful : )
Regards,
0 - When there is a hover state over an element it means that it is interactive, so there must be an interactive element around it (like a link or a button). So, we should use a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord