NFT preview card using HTML and CSS

Community feedback

• 

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  Great Job! Looks like you have nailed all the requirements.

  I have a few suggestions :

  1. For hover, try using hsla with 0.5, you will get a much transparent background.
  2. Try to avoid using h4, h5 for sizing. Using <p> and style as required.
  3. Try to avoid <br> in text. Let the text wrap according to the container size.
  4. Instead of <hr> you may also use border-bottom or border-top on one of the adjacent blocks.

  Somethings, I have read recently. Hope it helps you too.

  • h4, h5 like headings, <BR>, <hr> are mostly used in text intensive articles for separating different sections of it, not really for sizing.
  • Use divs sparingly and use them to group related elements on which you want to apply styles.

  Marked as helpful

  0

  ---

  

  Edem•50

  @CarlEdem97Posted almost 3 years ago

  @BikeInMan thanks a lot for the response and suggestions, they really helpful and I'll implement them

  0
• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Congrats on completing the challenge, @CarlEdem97!

  Your solution looks nice and all the features are there as required.

  Just a few observations based on your final solution and Github code repo:

  • There are some scrolling issues on smaller screen sizes. You might want to readjust the responsiveness of your design

  • You can use flex display to align the text and icons instead of using relative positioning

  • Your box shadow is incredibly big and the offset is exaggerated. Try changing the values you use for the box shadow

  0

  ---

  

  Edem•50

  @CarlEdem97Posted almost 3 years ago

  @Remus432 thanks for the feedback, Its much appreciated

  0