Design comparison
SolutionDesign
Community feedback
- @rayaattaPosted 10 months ago
Hello 👋 Celine.nice solution 👏
I have some suggestions you might find interesting.
1 Since the avatar image is not decorative fill out its alt attribute with the name of the person on the image i.e
alt="Jules wyvern"
2 Remove the
<div class= "attribution">
from the main and change it to<footer class="attribution">
And wrap it's text inside ap
element. This improves accessibility and SEO since it is much more semantic.I hope this helps , otherwise great solution 😉
Happy coding 🙃
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord