NFT Preview Card using flexbox

Community feedback

• 

  Mohammed Fakih•1,590

  @javascriptor1Posted over 1 year ago

  Hi Umut Yılmaz Gündüz ,

  Excellent job. As for the design , The active state is not complete. When hovering over the main image , the overlay should be applied with view icon. Give it a look.

  I liked how perfect your design in terms of matching the size ( dimentions width - height ) with the challenge.

  I would appeciate if you tell us about your process of measuring the sizes to acheive perfect pixel design.

  Best of luck 👌

  1

  ---

  

  Umut Yılmaz Gündüz•150

  @UmutYGPosted over 1 year ago

  Hi @javascriptor1, Thanks for the comment, It seems I missed the active part for sure :) I will fix it as soon as possible, thanks! I actually use Figma for the sizes, so I do not try to calculate every possible pixels, that is why it looks so matchy, I know it is hard to guess pixels without figma, feel free to copy the sizes from my repository for a better match for your design! Thank you again! Good luck!

  1

  

  Mohammed Fakih•1,590

  @javascriptor1Posted over 1 year ago

  Thank you so much @UmutYG

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="card"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1