Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card using Flex, positions, z-index and some luck

@ro-andrade

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello there!

So, this was, the most challenging one until now, mostly for the image hover effect. Pulled it of using positions, z-indexes and some luck. It took 2 nights to figure it out, but IT FELT SO REWARDING to finally see it working! Still kinda glitchy though, so if anyone knows how to correctly fix please feel free to give a feedback.

The rest of the stuff was pretty familiar to the QR one, so I used some stuff from there.

Oh, right. Finally been able to fix the footer problem that annoyed me in the last challenge!

Anyhow, thank you very much for your time checking my code, and, again, feel free to comment about how can I improve the code.

See you next time

Community feedback

PhoenixDev22 16,950

@PhoenixDev22

Posted

Hi ro_andrade,

Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

HTML

  • To tackle the accessibility issues in this challenge , you can have<h1>visually hidden with sr-only class.
  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways: 1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

For the same reason, you can use <a> to wrap Equilibrium #3429 and Jules Wyvern.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.
  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in ( icon-view, icon-ethereum, icon-clock ).
  • Images must have alt attribute. Profile images like that avatar are valuable content. The alternate text of the avatar’s image is needed. You can use the creator's name Jules Wyvern. Read more how to write an alt text
  • For middle part of the card lass="priceTime", you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.
  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <div class="line"></div>you can use border-top: to the avatar's part.
  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.
  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

hopefully this feedback helps.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord