NFT preview card using flex and grid

Community feedback

• 

  IRVINE MESA•1,855

  @DrMESAZIMPosted almost 3 years ago

  hi @RikkaaDev I had the opportunity to read your code .I believe its good work , well done especially on the commenting in the CSS file

  Marked as helpful

  1
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted almost 3 years ago

  Hello @RikkaaDev,

  I have some suggestions regarding your solution:

  • Anything with a hover style in a design means it's interactive. you need to add an interactive element around the image.

  • never use span for meaningful content. It would be better `

  <p class="credits">Creation of <a href="#">Jules Wyvern</a></p>
  
  

  • For any decorative images, each img tag should have empty alt="" andaria-hidden="true"attributes to make all web assistive technologies such as screen reader ignore those images in alt="eth-icon" alt="clock-icon">

  • the link should be wrapping the original image and either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • The avatar's alt text shouldn't be alt="profile-pic". You can use Jules Wyvern as an alt text.

  • You can read more about alt text

  • better to use min-height: 100vh; to the .container, using vh (viewport height) units to allow the body to set a minimum height value based upon the full height of the viewport.

  Overall , your solution is good , Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  -_RIkka•140

  @devsimocastlesPosted almost 3 years ago

  @PhoenixDev22 I need to study HTML accesibility I guess, thanks for the feedback!

  1
• 

  -_RIkka•140

  @devsimocastlesPosted almost 3 years ago

  Thanks!

  0