NFT Preview Card Using CSS Flexbox

Community feedback

• 

  Adriano•38,040

  @AdrianoEscarabotePosted about 2 years ago

  Hello everything is fine?

  I really liked the result of your project, but I have some tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside a main tag.

  2- Page should contain a level-one heading click here

  The rest is very good! Hope it helps... 👍

  Marked as helpful

  2

  ---

  

  Rishi•200

  @fushinoriPosted about 2 years ago

  @AdrianoEscarabote Thank you!

  1
• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Rishi, congrats finishing the challenge! pretty nice NFT solution, almost got it pixel perfect

  Your effect on hover for the overlay of the image looks good for me, I'm not that much of a fan of doing it this way cause is a bit of a mess to try getting some transitions on it, you could also have archieved it adding the background-color to the wrapper div, and playing with the opacity of the image on hover!

  Since this is a lonely component, I think you should go straight for a main tag, with its corresponding h1, but in largest project probably an article as you defined would make sense.

  Hope my feedback helps you, if you have any questions on how to get the hover effect with the wrapper div background, don't hesitate to ask!

  Marked as helpful

  2

  ---

  

  Rishi•200

  @fushinoriPosted about 2 years ago

  @DavidMorgade Ah, I guess I made it more complicated than it needs to be. Thank you!

  1

  

  Rishi•200

  @fushinoriPosted about 2 years ago

  @DavidMorgade Changing the opacity of the image on hover works for the most part. However, when I hover on the eye icon instead, the opacity of the image goes back to normal.

  If I add the the icon's hover selector too, then the opacity of the icon would go down too.

  Any idea how to keep the effect when hovering over both the icon and the image?

  Thank you in advance!

  1

  

  David•8,000

  @DavidMorgadePosted about 2 years ago

  @fushinori can you pass me a Git state where you added this effect to see things more clearly ?!

  Thanks a lot I really want to help you to get this effect!

  0

  

  Rishi•200

  @fushinoriPosted about 2 years ago

  @DavidMorgade Here you go.

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  HelloRishi,

  Congratulation on completing this frontend mentor challenge. Excellent work! I have some suggestions regarding your solution:

  • You can use<main>` for the NFT card. [HTML5 landmark elements are used to improve navigation](https://web.dev/use-landmarks/).There is no need for a <header>`` in this challenge.

  • The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ...) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2:If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  • You should have used <a>to wrap Equilibrium #3429 and Jules Wyvern too.

  • Page should at least have one level heading. you can have<h1>visually hidden with sr-only class.

  • The link wrapping the equilibrium image (image-equilibrium ) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock).

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • The alternate of the avatar image should not be Author avatar. You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Rishi•200

  @fushinoriPosted about 2 years ago

  @PhoenixDev22 Thank you for all the tips about accessibility. Most courses don't focus on the accessibility side of things so I'm really grateful for all the specific feedback!

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @fushinori

  Glad to hear that it was helpful. Happy coding!

  1