Design comparison
Solution retrospective
Feedback on best practices or CSS tips are welcome
Community feedback
- @elaineleungPosted over 2 years ago
Hi Mohammed, well done, your component looks great and quite like the original design :) Regarding best practices in CSS, I think generally having readable code that others can understand is probably most important, and that includes using descriptive names and not like
div1
. It's also generally good not to mix id and class tags. I find your code to be pretty clean and very readable; one thing you can try is to use custom variables; that way, you can reuse the variable throughout the code, and this is especially helpful for properties like color.Once again, good job, and keep practicing! :)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord