Alazar Getachew• 260
@AlazarG19
Posted
nice job just increase the scale and try changing the color of the line
Marked as helpful
0
@AlazarG19
Posted
nice job just increase the scale and try changing the color of the line
Marked as helpful
@denielden
Posted
Hi Nati, good job! I took some time to look at your code and have some ideas for improving it:
main
tag and wrap the card for improve the Accessibilityalt
attribute of the imagehr
a
tag instead span
for name of authormargin
from cont
class because with flex they are superfluoustransition
on the element with hover effectpx
try to use relative units of measurement -> read here<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom
because this line is decorativeOverall you did well 😉
Hope this help and happy coding!
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord