NFT Preview Card Solution using Tailwind CSS

Community feedback

• 

  Mehdi•990

  @siavhnzPosted about 2 years ago

  Hello Ozioma Odoemelam

  One solution for creating an image overlay is to use a div with opacity:0 next to the image.

  check out this great article on w3schools

  I did this challenge with Tailwindcss too, you can check out this link to see my solution, any feedback to improve my solution is welcome.

  I hope this helps you.

  Marked as helpful

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Ozioma Odoemelam,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • You should use <footer> for the attribution. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in icon-clock, icon-ethereum.

  • Profile images like that avatar are valuable content. The alternate text should not be empty .You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.

  • It’s not recommended to use <br> to increase the gap between lines of text Or make empty space between elements, use padding / margin styling via CSS. And about using <br> in the <p> to make the paragraph break in new line, You may use max-width to <p> and remove those <br>.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute, you can expose your site to performance and security issues.

  • Remember a css reset on every project that make all browsers display elements the same.

  Hopefully this feedback helps.

  0
• 

  Md5 dalton•1,430

  @md5daltonPosted about 2 years ago

  Hello Ozioma. Good work on your solution.

  You're not the first person to ask this, so I'll demonstrate below. You can achieve the hover state by creating a pseudo element of .cardimg:

  .cardimg {
      position: relative;
  }
  .cardimg::after {
      content: "";
      display: block;
      height: 100%;
      width: 100%;
      border-radius: 0.75rem;
      transition: .5s;
  }
  .cardimg:hover::after {
      background-color: hsla(178, 100%, 50%, 0.4); 
  }
  

  I hope that helps👌

  0