@denielden
Posted
Hi Vee, great work on this challenge! π
Here are a few tips for improve your code:
- to make it look as close to the design as possible decrease
padding
tocard
class - not use
<br>
to break the line of text - use
min-height: 100vh
instead ofheight
to.container
class - instead of using
px or %
use relative units of measurement likerem
-> read here
Overall you did well π Hope this help!
@JunasVee
Posted
@denielden Thanks for the feedback, Daniel.
The reason why I use % in every padding and margin is to make it adaptive.
If I was about to make a media query and drastically change a particular height or width of an element, I wouldn't need to set new padding or margin value in the same media query, but at the same time, I can have the same output-looking in different viewports.
Nevertheless, I'll definitely implement your useful tips. Why wouldn't I listen to a generous coder with 20K points ππ