Travolgi 🍕• 31,420
@denielden
Posted
Hi Jason, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - fix the wrong url of eye like this
<img class="icon-view" src="images/icon-view.svg">
and add descriptive text insidealt
- to make it look as close to the design as possible fix the position of hover effect adding
position: relative
to thearticle
tag container - remove all
margin
fromcenter-card
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Overall you did well 😁 Hope this help!
0