Design comparison
SolutionDesign
Community feedback
- @RioCantrePosted over 2 years ago
Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…
- Add
font-size: 22px;
in the header#product-name
rule set - Adjust the padding into
padding: 1rem 0;
in the.card-text
rule set - Instead of
div
, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics. Like this line<div class="card">
intomain
tag and<div class="attribution">
with footer tag. - Remove the
br
in the code. You can adjust the it with padding or margin
In the brighter side.
- Well done on the hover state of the hero image. You did well on utilizing the overlay effect.
- The CSS file is well structured. Great details on the media queries
- The design is well implemented and responsive.
- Good job in adding description in your code.
Above all, The project is awesome! Keep it up!
Marked as helpful0@samuelms21Posted over 2 years ago@RioCantre Thank you, this is really helpful. Yeah adding the <br> tag is a bad habit of mine.
0 - Add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord