NFT preview card, mobile first with CSS, flexbox and HTML5
Design comparison
Solution retrospective
Hi, i'm always worried if my code is well structured and is easily comprehensible to others.. what y'all think?
Community feedback
- @techantherePosted almost 3 years ago
This is the coolest solution I have seen so far, the CSS code is quite explainable especially the parts including the image overlay effect, which gave a different solution to me to tackle this problem. But please add the main element tag which will contain the main content of the page. Semantic tags are very important!
Marked as helpful0@nogyuuuPosted almost 3 years ago@techanthere thanks for the reply, i'm really glad you liked it! That part with the image overlay was the most difficult part to me.. couldn't get it working with z-indexes or making the whole cyan + eye icon in the same element :(
0 - @Robert-RynardPosted almost 3 years ago
Yeah I would say it's pretty easy to read. I got a little confused reading your CSS file though because of the indents on some of the classes. It made me think they were nested selectors like in SASS but seems like you were using those indents to indicate the BEM architecture. Not sure what the best practice is on that. But anyways solution looks great nice job!
Marked as helpful0@nogyuuuPosted almost 3 years ago@Robert-Rynard thank you so much for the reply! i'm not sure either what is the best practice, but while i'm coding it makes things easier for me to find things in the code when it's too big.. maybe i can put it the usual style after finishing the code
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord