NFT Preview Card (HTML & CSS)

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi demy,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • You can use the <main> landmark to wrap the NFT. And <footer> landmark to wrap the attribution, using landmarks is important to improve navigation experience on your site for users of assistive technology

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason, you can use <a> to wrap Equilibrium #3429 .

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be avatar. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • For middle part of the card id="ETH", you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  • Jules Wyvern needs an interactive element which is <a> not <mark> tag to be highlighted.

  • Really important to keep css specificity as low/flat as possible. It’s not recommended use the id's to target the DOM elements for styling purposes , using ID's creates problems due to the specificity , better to use class so that it could be more manageable and reusable.

  Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  demy•190

  @DemyttenaerePosted about 2 years ago

  @PhoenixDev22 Hello and thank you very much for taking the time to help me. I'm going to start this challenge again following your advice. Do you have a social network where it would be easier to talk?

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @Demyttenaere Glad to help. Actually you don’t need to start the challenge again, just update your solution in the GitHub repository.

  You can use frontend mentor platform, if you have any question about the challenges . Happy coding!

  Marked as helpful

  0

  

  demy•190

  @DemyttenaerePosted about 2 years ago

  @PhoenixDev22 By analyzing your solution and your answer, I was able to understand a lot of things. Now I better understand the importance of classes, the use of links, alt text and the hover effect! Thanks again !

  0