NFT Preview Card

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <h2> with <h1> to fix the accessibility issue.

  There is no need to give the body a min-height value.

  To center .card on the page using grid, add min-height:100vh to the body.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  2

  ---

  

  Konstantin Kamenskiy•50

  @Grendaizo90Posted almost 2 years ago

  @Hassiai Thanks for review! I added min-width: 375px to body to avoid overflowing visible content over window borders (sorry for bad english :) ), so that if i change width of screen less than 375px, content will not overflow, it will reduce

  0

  

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  @Grendaizo90, then give the content a max-width that will do wat you want.

  0
• 

  Muhammadh•1,140

  @Mr-jawPosted almost 2 years ago

  Hi there! 👋

  some accessibility issues can be fixed

  • replace <div class="attribution"> with the footer tag (i.e <footer class="attribution"> ... </footer>)

  • In the <div class="flex-group"> ... </div> rather than using <p> tag use either <em> or <strong> tag to improve accessibility. since <p> is used for paragraphs mostly and not for short text.

  I hope this was useful 😊

  KEEP GOING! 💪

  Marked as helpful

  0