Skip to content
Submitted about 2 years ago

NFT preview card

Mohit Mummon•530
@Mohit-k-Mummon
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Really enjoyed building this. I feel like my html structure was a little bloated. Please let me know what you think. Appreciate it!

Community feedback

  • Travolgi 🍕•31,400
    @denieldenPosted about 2 years ago

    Hi Mohit, congratulations on completing the challenge, great job! 😁

    Some little tips for optimizing your code:

    • add main tag and wrap the card for improve the Accessibility
    • also you can use article tag instead of a simple div to the container card for improve the Accessibility
    • remove all margin from card class because with flex they are superfluous
    • instead of using px use relative units of measurement like rem -> read here

    Hope this help! Happy coding 😉

    Marked as helpful
    0
    Mohit Mummon•530
    @Mohit-k-MummonPosted about 2 years ago

    @denielden Thanks for the feedback!

    1
    Travolgi 🍕•31,400
    @denieldenPosted about 2 years ago

    @Mohit-k-Mummon you are welcome and keep it up :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord